Open
Conversation
nemoguigrat
reviewed
Apr 20, 2025
| implementation("org.springframework.boot:spring-boot-starter") | ||
| implementation("org.springframework.boot:spring-boot-starter-web") | ||
| implementation("org.springframework.boot:spring-boot-starter-validation") | ||
| implementation("org.projectlombok:lombok:1.18.30") |
| @Service | ||
| @Validated | ||
| public class ArticleService { | ||
| public String create(@Valid ArticleIn article) { |
There was a problem hiding this comment.
Вообще такой подход имеет место (использовать аннотации валидации на уровне сервиса) и как правило применяется не к самому сервису, а к его интерфейсу. Но все же, на будущее, следует валидации выполнять на уровне контроллера. Как правило во всех проектах у тебя должны быть обработчики и на MethodArgumentNotValidException, и на ConstraintViolationException
|
|
||
| @PostMapping("/create") | ||
| @ResponseStatus(HttpStatus.CREATED) | ||
| public String register(@RequestBody ArticleIn article) { |
| import org.javaspringcourse.validation.Title; | ||
|
|
||
| @Data | ||
| public class ArticleIn { |
There was a problem hiding this comment.
Начиная с java 17 для дто следует использовать record, когда это возможно. Или хотя бы использовать @Value из lombok вместо @Data, т.к. дто должны быть неизменяемыми
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Студент: Аптуликсанов Руслан Германович.
Преподаватель: Никита Иванов
RussianFullName,RussianFullNameConstraintValidatorиArticleExceptionHandler)Title)